Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: type safety improvements #383

Merged
merged 8 commits into from
Oct 4, 2023
Merged

refactor: type safety improvements #383

merged 8 commits into from
Oct 4, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented May 22, 2023 •
edited
Loading

Description

Type safety improvements by using encodeCall instead of encodeWithSelector as well as more explicit syntax.

Task: OS-691

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@heueristik heueristik marked this pull request as draft May 22, 2023 08:07
@heueristik heueristik changed the title Various Improvements Various Contract Improvements May 24, 2023
@heueristik heueristik force-pushed the feature/various-improvements branch from a59e3d0 to a7b662b Compare June 2, 2023 08:41
Rekard0
Rekard0 reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the content of this doc is addressed https://www.notion.so/aragonorg/Architectural-Tech-Debt-Discoveries-629325f528ad455d9c7b7e99c52f5f01?pvs=4

@heueristik heueristik changed the title Various Contract Improvements refactor: type safety improvements Aug 30, 2023
@heueristik heueristik marked this pull request as ready for review September 28, 2023 07:31
mathewmeconry
mathewmeconry previously approved these changes Sep 28, 2023
View reviewed changes
@heueristik heueristik merged commit e35f6f8 into develop Oct 4, 2023
12 checks passed
@heueristik heueristik deleted the feature/various-improvements branch October 4, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathewmeconry mathewmeconry mathewmeconry approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @mathewmeconry @Rekard0